fix(docker): make docker-compose runnable standalone#49
Merged
Conversation
The service declared depends_on the Honcho 'api' service, which doesn't exist in this standalone compose — 'docker compose up' failed with 'depends on undefined service api'. Drop the dependency, default HONCHO_UPSTREAM to the host's Honcho (host.docker.internal:8000, overridable), and add an extra_hosts mapping so the default also resolves on Linux. Combined-stack instructions moved to comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
docker compose upfailed out of the box:The compose was written as a snippet to drop into a Honcho stack (which provides
api), but as a standalone file thedepends_on: apiis invalid.Fix
depends_on: api— the blocker.HONCHO_UPSTREAMtohttp://host.docker.internal:8000(overridable:HONCHO_UPSTREAM=… docker compose up) so it points at a Honcho on the host with zero config.extra_hosts: host.docker.internal:host-gatewayso that default resolves on Linux too (Docker Desktop/Colima already provide it).Verified locally
docker compose configvalidates;docker compose upstarts the container,/healthzreturns ok,config.jsinjectssame-origin. No undefined-service error.Patch (
fix) → cuts v0.13.1, which re-publishes the image to the now-linked GHCR package.