fix(release): regenerate and commit Cargo.lock on release#5
Merged
offendingcommit merged 1 commit intomainfrom May 3, 2026
Merged
fix(release): regenerate and commit Cargo.lock on release#5offendingcommit merged 1 commit intomainfrom
offendingcommit merged 1 commit intomainfrom
Conversation
Previously the release workflow updated Cargo.toml's version via sed but never refreshed Cargo.lock, leaving it one version behind after every release. Add cargo update for the openconcho package to the prepareCmd, and add Cargo.lock to @semantic-release/git assets so it ships in the release commit. Also bumps the lagging 0.5.1 -> 0.5.2 lockfile entry that the 0.5.2 release missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Each release runs
sedagainstpackages/desktop/src-tauri/Cargo.tomlto bump the crate version, butCargo.lockis never regenerated and isn't in the@semantic-release/gitasset list. Result: every release commit leavesCargo.lockone version behind, producing dirty working trees onmainimmediately after release.Currently visible:
Cargo.locklistsopenconcho v0.5.1while the toml is0.5.2.Fix
prepareCmdnow also runscargo update -p openconcho --manifest-path packages/desktop/src-tauri/Cargo.tomlto refresh the lockfile in lockstep.Cargo.lockadded to@semantic-release/gitassets so it ships in the release commit.0.5.1 -> 0.5.2entry that the 0.5.2 release missed, so this PR leaves the tree clean.Notes
cargoon the release runner (already present — release uses tauri-action).