chore(dx): refresh CLAUDE.md, consolidate commands behind make, add editor config#6
Merged
offendingcommit merged 2 commits intomainfrom May 3, 2026
Merged
Conversation
- Fix commands (pnpm dev runs Tauri; add web filter, typecheck, test:e2e)
- Add packages/{web,desktop} structure
- Note catalog, commitlint, semantic-release, gh account conventions
- Make is the canonical interface; pnpm scripts wrap turbo, make wraps pnpm - CI now calls `make ci-web` / `make ci-desktop` so local == CI - Add .nvmrc (node 24, matches CI) + engines field - Add .editorconfig and .vscode (extensions + settings) - Add `pnpm bootstrap` (deps + Playwright Chromium) - Add `dev:web` / `dev:desktop` shortcuts - CONTRIBUTING.md: lead with `make bootstrap`/`make dev-web`, link Tauri prereqs, fix wrong `pnpm dev` claim - CLAUDE.md: command table reflects make-first workflow
offendingcommit
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The original goal was a stale-CLAUDE.md fix; while in there, bundled the rest of the contributor onboarding gaps that were tripping people up.
What changed
Docs
pnpm devlie; lead withmake bootstrap+make dev-web; link to Tauri prereqs; referencemake help.Single command interface —
makeMakefileis now the canonical entry point. CI calls the same targets (make ci-web,make ci-desktop), so anything that passes locally passes in CI.make helpself-documents every target.New scripts
pnpm bootstrap(make bootstrap) — install deps + Playwright Chromium with system deps.pnpm dev:web/pnpm dev:desktop— no more typingpnpm --filter @openconcho/web dev.pnpm check— lint + typecheck + test in one shot.pnpm ci:web/pnpm ci:desktop— what CI runs.pnpm lint:fix/pnpm format— Biome auto-fix at the root.Toolchain alignment
.nvmrcpins Node 24 (matches the CI setup action).enginesfield signals Node ≥22 / pnpm ≥10.packageManageralready pinned pnpm exactly.Editor experience
.editorconfig— tabs, LF, trim trailing whitespace, UTF-8..vscode/extensions.json— recommends Biome, Tauri, rust-analyzer, Tailwind, EditorConfig, Playwright..vscode/settings.json— Biome as default formatter, format-on-save, organize-imports/quickfix on save, exclude generated files (schema.d.ts,routeTree.gen.ts) from search..gitignoreallowlists.vscode/settings.json.CI
.github/workflows/ci.yml—pnpm turbo ...calls replaced withmake ci-web/make ci-desktop. Same behavior, single source of truth.DX before → after
pnpm install, then guess about Playwrightmake bootstrappnpm --filter @openconcho/web dev(38 chars)make dev-webmake check && make buildmake help.nvmrc+ corepackSkipped (filed for follow-ups elsewhere or out of scope)
Closes nothing directly; sets up future contributors for success.