fix: broken pipeline error#23
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a “broken pipe”/EPIPE scenario in the release pipeline by changing determine_bump to keep consuming stdin after detecting a major bump, and adds a regression test intended to ensure the upstream producer doesn’t hit SIGPIPE.
Changes:
- Update
determine_bumpto “lock in”majorwhile continuing to read the full input stream (avoiding upstream EPIPE). - Add a Bats test that simulates a producer writing many commit messages into
determine_bumpafter an early breaking-change line.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
scripts/conventional.sh |
Keeps reading stdin after detecting a breaking change so upstream pipeline writers don’t hit EPIPE. |
tests/conventional.bats |
Adds a regression test intended to catch broken-pipe behavior when major is detected early. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+71
to
+76
| err=$( | ||
| { | ||
| echo "feat!: break stuff" | ||
| for i in $(seq 1 50); do echo "fix: thing ${i}"; done | ||
| } | determine_bump 2>&1 >/dev/null | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.