Conversation
added 3 commits
April 19, 2026 01:02
Shared code lives in scripting/include/offstyledb_core.inc. Two thin wrapper .sp files produce the two builds: - offstyledb.sp -> offstyledb.smx (shavit v4) - offstyledb_v3.sp -> offstyledb_v3.smx (shavit v3, defines SHAVIT_V3) Version-specific divergences are guarded by #if defined SHAVIT_V3: shavit native/forward decls, AddAdditionalReplayPathsHere vs ShouldSaveReplayCopy, OnReplaySaved signature, and the EnsureTempReplayDir/GetTempReplayPath helpers that only v4 needs.
v3 shavit doesn't ship these helpers via its include, and the v3 build of the unified source doesn't #include <shavit>, so declare them inline under SHAVIT_V3.
Member
Author
|
WE BALL HELLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared code lives in scripting/include/offstyledb_core.inc. Two thin wrapper .sp files produce the two builds:
Version-specific divergences are guarded by #if defined SHAVIT_V3:
shavit native/forward decls, AddAdditionalReplayPathsHere vs ShouldSaveReplayCopy, OnReplaySaved signature, and the EnsureTempReplayDir/GetTempReplayPath helpers that only v4 needs.