Closed
Conversation
Convenience functions for shorthand only flags
Owner
|
Adding a whole bunch of extra methods with yet another cryptic suffix doesn't sound attractive. Hiding the shorthand in the name field is also very hacky, and probably makes error messages worse. It would be much more elegant to make the |
ThinkChaos
pushed a commit
to ThinkChaos/pflag
that referenced
this pull request
Feb 28, 2022
Declare Flag{ by name instead of order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted flags that can only be specified as
-fand not--f. Mainly because it allows for the help to look better.I think this type of flag is mostly useful for bool flags, but I added convenience methods/functions for all flag types by adding
Sto the name:BoolS.For
BoolS("f", false, "blah")the help is:-f=false: blah.