Skip to content

fix CD filter#6

Merged
ohadschn merged 1 commit intomainfrom
fix-workflow-run-filter
Jan 18, 2026
Merged

fix CD filter#6
ohadschn merged 1 commit intomainfrom
fix-workflow-run-filter

Conversation

@ohadschn
Copy link
Owner

only branch filter is necessary as explained in the comment The additional filters were either redundant or incorrect:

  1. github.event_name is always workflow_run anyway
  2. workflow_run.event can't be 'pull_request' because such a run's branch would never match main (see comment)
  3. github.event.workflow_run.head_repository.fork is true for this repo because it's a fork in itself

only branch filter is necessary as explained in the comment
The additional  filters were either redundant or incorrect:
1. `github.event_name` is always `workflow_run` anyway
2. `workflow_run.event` can't be 'pull_request' because such a run's branch would never match `main` (see comment)
3. `github.event.workflow_run.head_repository.fork` is true for this repo because it's a fork in itself
@ohadschn ohadschn merged commit cc96fc8 into main Jan 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant