test(core): add integration tests for viewer conversion functions#33
Closed
test(core): add integration tests for viewer conversion functions#33
Conversation
ohah
added a commit
that referenced
this pull request
Feb 25, 2026
Tests ParagraphPosition, ParagraphRenderContext, ParagraphRenderState, render_paragraphs_fragment, and helper functions (collect_*). Covers struct field access and empty edge cases.
ohah
force-pushed
the
test/viewer-conversion-integration-tests
branch
from
6af5244 to
849b8f0
Compare
ohah
added a commit
that referenced
this pull request
Feb 25, 2026
Tests ParagraphPosition, ParagraphRenderContext, ParagraphRenderState, render_paragraphs_fragment, and helper functions (collect_*). Covers struct field access and empty edge cases.
ohah
added a commit
that referenced
this pull request
Feb 25, 2026
Tests ParagraphPosition, ParagraphRenderContext, ParagraphRenderState, render_paragraphs_fragment, and helper functions (collect_*). Covers struct field access and empty edge cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
테스트 추가/보강. viewer 모듈의 다양한 변환 함수(to_markdown, to_html, to_pdf)에 대한 통합 테스트를 추가함.
toJson() → fileHeaderJson() (파서 타겟이어서 기존에 존재하여 제외)
to_markdown() → Markdown 변환 검증
to_html() → HTML 변환 검증
to_pdf() → PDF 변환 테스트 (금지됨. 글꼴 필수라 자동으로 skip됨)
resolve_display_texts() → 표시 텍스트 해결 메서드 검증
기능: 실제 HWP 파일(hwpjs/fixtures/noori.hwp) 또는 최소 유효 FileHeader 사용
7개 테스트 통과 (1개는 금지됨/사실상 스킵됨)
조건: 실제 HWP 파일이 fixtures에 존재해야 함 (테스트가 해당 경로를 찾으면 실행)
리뷰 후 머지.