refactor: /simplify 리뷰 반영 — 매직 넘버, 테스트 수정#809
Merged
Conversation
- codegen: 0x80000000 → Ast.STRING_TABLE_BIT 상수 참조 - runtime_helpers: TOESM_RUNTIME_CONFIGURABLE 중복 주석 정리 - hermes-runtime.test: __copyProps 테스트를 새 Rolldown 호환 구현으로 업데이트 (Object.keys().forEach → getOwnPropertyNames + for 루프) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Smoke Test Results (CI)Smoke Test Results
Size Comparison (ZTS vs esbuild)
Average ratio: 0.96x | Smaller: 122 | Similar(±10%): 1 | Larger: 8
|
Benchmark Results (CI)macos-latesttranspile — small (100 lines)
transpile — medium (1K lines)
transpile — large (5K lines)
bundle — small (10 modules)
bundle — medium (50 modules)
bundle — large (200 modules)
ubuntu-latesttranspile — small (100 lines)
transpile — medium (1K lines)
transpile — large (5K lines)
bundle — small (10 modules)
bundle — medium (50 modules)
bundle — large (200 modules)
windows-latesttranspile — small (100 lines)
transpile — medium (1K lines)
transpile — large (5K lines)
bundle — small (10 modules)
bundle — medium (50 modules)
bundle — large (200 modules)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codegen.zig:0x80000000→Ast.STRING_TABLE_BIT상수 참조runtime_helpers.zig: 중복 주석 정리hermes-runtime.test.ts:__copyProps테스트를 Rolldown 호환 구현으로 업데이트 (깨진 테스트 수정)Test plan
zig build test— 전체 통과bun test tests/hermes-runtime.test.ts tests/runtime-helpers.test.ts tests/bundle-smoke.test.ts— 116개 통과🤖 Generated with Claude Code