fix(parser): ?? + && mixing detection + docs update#167
Merged
Conversation
The existing check only caught ?? and &&/|| in the same recursive frame. When && had higher precedence and was parsed as the right operand of ??, the mix was undetected. Now checks if the right-hand side of ?? is a logical_expression with && or || operator, reporting the error. Example: 0 ?? 0 && true → SyntaxError (ECMAScript) Test262: 471 → 470 failures (98.0%, +1 test) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Update semantic analysis checklist to reflect completed work: - PR #163-167: visitor coverage, checker.zig, strict octal, duplicate params, ?? mixing Test262: 528 → 470 failures (97.7% → 98.0%) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
??오른쪽 피연산자에서 괄호 없는&&/||혼용 검출 수정0 ?? 0 && true미감지Test262 결과
전체 Semantic Early Error Checker 성과 (PR #163-167)
Test plan
zig build test— 유닛 테스트 통과zig fmt --check src/— 포맷팅 통과zig build test262-run— 통과율 확인 (98.0%)🤖 Generated with Claude Code