feat(parser): cover grammar edge case validation#174
Merged
Conversation
- Object rest-not-last: {...rest, b} → SyntaxError
- Method in destructuring: [{ get x() {} }] = [] → SyntaxError
- Array rest trailing comma: [...x,] → SyntaxError
(parseArrayExpression에서 spread+comma+] 감지, flags 0x01 마킹)
Test262: 457 → 436건 (-21건), 98.1%.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- 연산자 우선순위 수정: (flags & 0x01) != 0 괄호 추가 - 매직 넘버 0x01 → spread_trailing_comma 상수로 추출 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{...rest, b}→ SyntaxError[{ get x() {} }]→ SyntaxError[...x,]→ SyntaxErrorparseArrayExpression에서 spread+comma+]패턴 감지, flags 0x01 마킹coverArrayExpressionToTarget에서 flags 확인 후 에러 보고Test plan
zig build test통과zig fmt --check src/통과zig build test262-run436건 실패 (457 → 436, -21건), 98.1%🤖 Generated with Claude Code