fix(parser): reject meta_property as assignment target#175
Merged
Conversation
import.meta and new.target should never be valid assignment targets. Previously they fell through to the else branch which only errored when is_top=true, allowing them to silently pass in nested destructuring positions like [import.meta] = arr. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import.meta와new.target(meta_property 노드)을 assignment target으로 명시적 거부else브랜치에서is_top=true일 때만 에러 → 중첩 destructuring에서 누락is_top무관하게 항상 에러Test plan
zig build test통과zig fmt --check src/통과zig build test262-runimport.meta 관련 개선 확인🤖 Generated with Claude Code