fix(semantic): resolve escape sequences in private name comparison#182
Merged
fix(semantic): resolve escape sequences in private name comparison#182
Conversation
ECMAScript specifies that private names should be compared by their
StringValue (after resolving escape sequences), not by raw source text.
For example, #\u{6F} and #o are the same private name.
Added resolvePrivateName() that decodes unicode escape sequences (\uXXXX
and \u{XXXX} forms) before comparison in collectPrivateNames and
usePrivateName paths.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- ArrayList.dupe → toOwnedSlice로 이중 할당 제거 - OOM 시 silent fallback → @Panic (프로젝트 컨벤션) - codepoint > 0x10FFFF 범위 검증 추가 - u21 intCast 안전성 확보 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#\u{6F}와#o를 동일한 private name으로 인식resolvePrivateName()메서드 추가 (analyzer.zig)Test plan
zig build test통과zig fmt --check src/통과🤖 Generated with Claude Code