fix(parser): class body strict mode + escaped keyword validation#184
Merged
fix(parser): class body strict mode + escaped keyword validation#184
Conversation
ECMAScript 10.2.1 specifies that all parts of a class (name, extends, body) are strict mode code. Set is_strict_mode=true when entering parseClassWithDecorators so that: - yield/let/static as class names produce SyntaxError - escaped forms (yi\u0065ld, l\u0065t, st\u0061tic) are also rejected - yield in method default parameters (x = yield) is caught Also fix escaped_keyword handling to allow escaped await (aw\u0061it) as an identifier in script mode, since await is only reserved in Module goal per ECMAScript 12.1.1. Fixes 9 Test262 failures in expressions/class/. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
zig build test통과zig fmt --check src/통과🤖 Generated with Claude Code