fix(bundler): export *에서 default export 제외 (ESM 스펙 준수)#457
Merged
Conversation
ECMAScript 15.2.3.5 — export *는 "default"를 제외해야 함.
collectExportsRecursive에서 export * 재귀 진입 전에 seen에 "default" 추가.
직접 선언된 export { default }는 영향 없음 (첫 루프에서 이미 수집).
- date-fns 251→250 (esbuild/rolldown 동일)
- graphql, mobx, neverthrow 등 이미 일치 확인
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Benchmark Results (CI)macos-latesttranspile — small (100 lines)
transpile — medium (1K lines)
transpile — large (5K lines)
bundle — small (10 modules)
bundle — medium (50 modules)
bundle — large (200 modules)
ubuntu-latesttranspile — small (100 lines)
transpile — medium (1K lines)
transpile — large (5K lines)
bundle — small (10 modules)
bundle — medium (50 modules)
bundle — large (200 modules)
windows-latesttranspile — small (100 lines)
transpile — medium (1K lines)
transpile — large (5K lines)
bundle — small (10 modules)
bundle — medium (50 modules)
bundle — large (200 modules)
|
Smoke Test Results (CI)Smoke Test Results
Size Comparison (ZTS vs esbuild)
Average ratio: 1.00x | Smaller: 114 | Similar(±10%): 2 | Larger: 9
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ECMAScript 15.2.3.5 —
export *는default를 제외해야 함.Changes
collectExportsRecursive에서export *재귀 진입 전에 seen에"default"추가export { default }는 영향 없음 (첫 루프에서 이미 수집)Comparison (date-fns)
Test plan
🤖 Generated with Claude Code