[ENG-346] Add required variable to staging settings#3658
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adds an explicit ChangesStaging Production Mode Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR adds
Confidence Score: 4/5Safe to merge; the one-line addition is correct and intentional, with a minor side effect on developer tooling worth confirming. The change is a single flag addition that aligns staging with production behavior. The notable side effect is that Swagger/API schema endpoints will silently disappear from staging after this lands, which could inconvenience developers — worth a quick confirmation before merging. config/settings/staging.py — confirm the Swagger endpoint loss on staging is acceptable. Important Files Changed
Reviews (1): Last reviewed commit: "Add required variable to staging setting..." | Re-trigger Greptile |
| # Your stuff... | ||
| # ------------------------------------------------------------------------------ | ||
|
|
||
| IS_PRODUCTION = True |
There was a problem hiding this comment.
Swagger/API schema docs disabled on staging
In config/urls.py, the swagger and API schema endpoints are only mounted when settings.DEBUG or not settings.IS_PRODUCTION. With IS_PRODUCTION = True now set here (and DEBUG typically False in staging), those endpoints will no longer be accessible on the staging environment. If developers rely on the staging Swagger UI for API exploration, this will break that workflow. This may be intentional, but it's worth confirming.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3658 +/- ##
===========================================
+ Coverage 75.46% 75.54% +0.07%
===========================================
Files 479 479
Lines 22984 22985 +1
Branches 2375 2375
===========================================
+ Hits 17344 17363 +19
+ Misses 5068 5051 -17
+ Partials 572 571 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ENG-346
Summary by CodeRabbit