Replaced useDispatch w. useQuery/request: Shifting (src/Components/Shifting/**)#6533
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
konavivekramakrishna
force-pushed
the
fix#6483
branch
from
8afac1e to
ffcb37d
Compare
rithviknishad
requested changes
Nov 3, 2023
rithviknishad
requested changes
Nov 6, 2023
konavivekramakrishna
force-pushed
the
fix#6483
branch
from
f89be30 to
be4a00c
Compare
rithviknishad
approved these changes
Nov 6, 2023
Member
rithviknishad
left a comment
rithviknishad
left a comment
There was a problem hiding this comment.
Nice work @konavivekramakrishna LGTM
konavivekramakrishna
changed the title
Contributor
Author
|
@rithviknishad, |
Member
|
No @konavivekramakrishna |
Member
|
It's not your PR's fault |
Contributor
Author
|
Got it👍 |
Member
|
https://deploy-preview-6533--care-net.netlify.app/shifting/c8bcd2a4-ed41-4b64-ba27-96cd62a978dc this no comment is not in staging, so just remove it
pagination for the comments is breaking |
konavivekramakrishna
force-pushed
the
fix#6483
branch
from
f822986 to
3c4f224
Compare
Member
|
LGTM |
nihal467
added
Tested
cypress failed
khavinshankar
approved these changes
Nov 7, 2023
❌ Deploy Preview for care-net failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at a3582c4
The pull request refactors the shifting features of the frontend application to use the
useQueryhook and therequestfunction from theUtilsfolder, which simplify and improve the API requests and responses logic. The pull request also defines new interfaces for the shift and shift details data, and updates the existing interfaces and routes for the shifting features. The pull request also removes some unused and redundant code, and adds some user interface enhancements.Proposed Changes
useDispatchw.useQuery/request: Shifting (src/Components/Shifting/**) #6483@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at a3582c4
stateproperty optional in theFacilityModelinterface and theexclude_userprop optional in theFacilitySelectPropsinterface (link, link)useQueryandrequestfunctions from theUtilsfolder, which use theroutesobject and theaxioslibrary to make and handle API requests (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)routesobject, using theIShiftandIShiftDetailsinterfaces from themodelsfile and theTypefunction from theruntypeslibrary (link, link, link)routesobject, using theUserModelinterface and thePaginatedResponsetype (link)Commentinsrc/Components/Resource/CommentSection.tsx, which takes anICommentobject as a prop and renders the comment details (link)CommentSectioncomponent insrc/Components/Shifting/CommentsSection.tsxwith thePaginatedListcomponent from theCAREUIfolder, which handles the loading and pagination logic internally (link)src/Components/Shifting/ShiftDetails.tsxandsrc/Components/Shifting/ListView.tsx, which show messages based on the shift status or confirmation (link, link)src/Components/Shifting/ShiftDetails.tsx, which allow the user to make a call or navigate to the patient details page by clicking on them (link, link)offsetstate variable insrc/Components/Shifting/ShiftingBoard.tsx, which is used to keep track of the pagination offset for the API request (link)