Skip to content

Syncing package-lock with package.json for cypress#6589

Merged
khavinshankar merged 8 commits into
developfrom
fix-flaky-user
Nov 11, 2023
Merged

Syncing package-lock with package.json for cypress#6589
khavinshankar merged 8 commits into
developfrom
fix-flaky-user

Conversation

@nihal467
Copy link
Copy Markdown
Member

@nihal467 nihal467 commented Nov 11, 2023

WHAT

🤖 Generated by Copilot at 3e3d505

This pull request updates the cypress tests and dependency for the user management and shifting features. It adds user skill testing, fixes a role name mismatch, and improves the test reliability and assertions.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 3e3d505

  • Update cypress dependency to latest version for new features and bug fixes (link)
  • Change role name for dummy shifting user to match backend (link)
  • Import and instantiate UserCreationPage class for user management test (link, link)
  • Modify user management test to include steps for adding, verifying and removing a skill for a user (link)
  • Intercept and assert GET users API call in navigateToProfile method of ManageUserPage.ts (link)

@nihal467 nihal467 requested a review from a team November 11, 2023 06:19
@nihal467 nihal467 requested a review from a team as a code owner November 11, 2023 06:19
@nihal467 nihal467 requested a review from mathew-alex November 11, 2023 06:19
@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2023 6:20am

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 11, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 79d919a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/654f1cf141d94f0008c89ae9
😎 Deploy Preview https://deploy-preview-6589--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad
Copy link
Copy Markdown
Member

Caused by cypress upgrade from #6583

@cypress
Copy link
Copy Markdown

cypress Bot commented Nov 11, 2023

Passing run #1570 ↗︎

0 85 0 0 Flakiness 0

Details:

Syncing package-lock with package.json for cypress
Project: CARE Commit: 79d919aeaf
Status: Passed Duration: 03:46 💡
Started: Nov 11, 2023 6:23 AM Ended: Nov 11, 2023 6:27 AM

Review all test suite changes for PR #6589 ↗︎

@khavinshankar khavinshankar merged commit 7e50f8a into develop Nov 11, 2023
@khavinshankar khavinshankar deleted the fix-flaky-user branch November 11, 2023 06:30
@github-actions
Copy link
Copy Markdown

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants