feat(knowledge): ADR-048 Phase 2 — resource kind, knowledge_sections, edit+import verbs#508
Conversation
… edit+import verbs - Add `resource` as 9th EntityKind (ADR-001 amendment) in khive-pack-kg/vocab.rs; aliases: atom, runbook, template, prompt, skill, tool - V20 no-op placeholder (reserved for brain section posteriors in PR #505) - V21 migration: `knowledge_sections` table with UNIQUE(atom_id, section_type), FTS5 virtual table + insert/update/delete triggers, three covering indexes - SectionType enum (10 variants) with from_str_loose() heading normalization - `knowledge.edit` verb: section-level upsert via ON CONFLICT DO UPDATE, preserves sibling sections, resolves atom by UUID or slug - `knowledge.import` verb: atlas markdown ingestion — parses # title + ## headings into section-typed atoms; supports section and atom chunk strategies - Register both verbs in KNOWLEDGE_HANDLERS (14 entries) and dispatch match Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
RuntimeConfig::default() now includes additional_embedding_models with ParaphraseMultilingualMiniLmL12V2, which gets registered in the DB and causes note-creation tests to attempt model loading. In CI, the ONNX model files don't exist, causing 5 integration tests to fail with "model initialization failed: IO error: No such file or directory". Fix: explicitly set additional_embedding_models: vec![] in all test RuntimeConfig blocks that set embedding_model: None. Also includes cargo fmt and deno fmt fixes for runtime.rs and ADR docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c8159732e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// Actionable content agents consume (ADR-048): atoms, domains, skills, | ||
| /// tools, templates, prompts, runbooks. | ||
| Resource, |
There was a problem hiding this comment.
When callers follow ADR-048's resource/atom linking pattern (e.g. resource --annotates--> concept), these newly accepted Resource entities cannot actually be linked: validate_edge_relation_endpoints still treats annotates as note-source-only and the base allowlist has no resource endpoints for the other semantic relations. As a result Phase 2 resources can be created but cannot participate in the intended KG relationships, so either the runtime/pack edge contract needs to be extended or the kind should not be exposed yet.
Useful? React with 👍 / 👎.
| json!({ | ||
| "section_type": stype.as_str(), | ||
| "heading": heading, | ||
| "content": body, |
There was a problem hiding this comment.
For markdown files containing two headings that normalize to the same SectionType (especially multiple unknown headings, all mapped to other), this import builds multiple updates with the same section_type. knowledge.edit upserts on UNIQUE(atom_id, section_type), so the later update overwrites the earlier section body and the imported file silently loses content while still counting both updates as imported sections. Group or concatenate same-type sections before calling edit, or reject duplicates explicitly.
Useful? React with 👍 / 👎.
Mark the markdown example block as `text` so the Rust doctest runner does not attempt to compile it as Rust source. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 participant
Summary
resourceas 9th EntityKind with subtypes: atom, runbook, template, prompt, skill, toolknowledge_sectionstable with FTS5 triggers and 3 indexesSectionTypeenum (10 variants matching ADR-048 §1): Overview, CoreModel, BoundaryConditions, Formalism, OperationalGuidance, Examples, FailureModes, ExpertLens, References, Otherknowledge.editverb: upsert per-section content with stable IDs on re-editknowledge.importverb: atlas_md parser with section+atom strategiesKNOWLEDGE_HANDLERSexpanded from 12 → 14Merge sequence
Position: 10/10 — merge after #507
Test plan
cargo check --workspacecleancargo test --workspacepasses (excl. 2 pre-existing memory failures)knowledge.editupserts sections with stable IDsknowledge.importparses atlas_md format🤖 Generated with Claude Code