test: Phase 1 MVP 정합성 검증 보강

[ohhalim]

작업 내용

• Phase 1 MVP 정합성 검증 테스트 보강
• 공통 정합성 검증 유틸 적용
• 실패 요청 부작용 검증 추가
• 오더북 복구 검증 추가
• 동시 요청 멱등성 검증 추가
• 3분 k6 soak 테스트 결과 문서화

검증 결과

• ./gradlew test --rerun-tasks 통과
• 전체 테스트 130개 통과
• k6 3분 부하 테스트 통과
• http_req_failed 0.00%
• server_errors 0
• 주문 생성 p95 63.16ms
• 조회 p95 16.69ms
• Hikari pending max 0

판단

Phase 1 MVP 기준에서 Kafka/WebSocket 도입 전 필요한 주문, 체결, 지갑, 원장, 오더북 정합성 검증을 완료했다.

관련 이슈

closes #34

Summary by CodeRabbit

• Documentation

  • Updated test results with Phase 1 MVP validation and 3-minute soak testing outcomes, including metrics and observations.

• Tests

  • Added concurrency testing to verify duplicate order handling and concurrent cancellation scenarios.
  • Added order book recovery tests to validate proper state restoration after system recovery.
  • Enhanced existing test suites with post-test system state validation across all core entities.
  • Introduced automated integrity verification across wallet balances, orders, trades, and ledger consistency.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR adds a comprehensive test integrity validation framework (IntegrityAssertions) that checks system invariants across wallets, orders, trades, ledgers, and matching engine state. The framework is integrated into all test suites via @AfterEach lifecycle hooks. The PR also introduces new concurrency and order book recovery test scenarios with expanded negative-case validation, and documents Phase 1 MVP consistency and soak test results.

Changes

Test Integrity Validation and Enhanced Test Coverage

Layer / File(s)	Summary
IntegrityAssertions validation framework src/test/java/com/coinflow/support/IntegrityAssertions.java	Core validation utility with constructor, assertAll() orchestrator, and six consistency-check methods validating wallet balances, order quantities, trade calculations, ledger state, and matching engine order book alignment.
Test infrastructure: @AfterEach integrity pattern src/test/java/com/coinflow/integration/ConcurrencyIntegrationTest.java, src/test/java/com/coinflow/integration/DomainEventTest.java, src/test/java/com/coinflow/integration/MatchingSettlementTest.java, src/test/java/com/coinflow/order/OrderApiTest.java, src/test/java/com/coinflow/query/QueryApiTest.java, src/test/java/com/coinflow/wallet/WalletApiTest.java	Adds MarketRepository autowiring and @AfterEach assertion lifecycle to six test classes, enabling post-test invariant validation across all test executions.
Concurrency tests: duplicate clientOrderId and idempotent cancel src/test/java/com/coinflow/integration/ConcurrencyIntegrationTest.java	CON_005 verifies 10 concurrent BUY orders with identical clientOrderId result in 1 success and 9 conflicts with correct wallet locking; CON_006 verifies 10 concurrent cancel requests on the same order result in 1 success and 9 rejections with correct balance restoration.
Order book recovery test suite src/test/java/com/coinflow/integration/OrderBookRecoveryTest.java	New test validating order book rebuild: verifies only OPEN and PARTIALLY_FILLED orders reappear after in-memory clear, confirms rebuilt orders can match new orders, and includes helper methods for user management, deposits, and order operations.
Enhanced negative-case assertions src/test/java/com/coinflow/order/OrderApiTest.java	Expands four failure-scenario tests to validate not only HTTP status/codes but also that persistent and in-memory state remain unchanged for insufficient-balance, invalid tick-size, duplicate clientOrderId, and self-trade rejection cases.
Test results documentation .docs/TEST_RESULTS.md	Adds section 7 documenting Phase 1 MVP consistency and soak verification with JUnit re-validation results, k6 3-minute soak test parameters, metrics, thresholds, and observation results; marks longer soak test follow-up as DONE.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

• ohhalim/CoinFlow#21: Both PRs modify src/test/java/com/coinflow/wallet/WalletApiTest.java; PR #21 adds wallet deposit tests while this PR adds @AfterEach integrity verification.
• ohhalim/CoinFlow#33: Both PRs extend src/test/java/com/coinflow/integration/ConcurrencyIntegrationTest.java with new Phase-1 concurrency scenarios and @AfterEach IntegrityAssertions teardown.
• ohhalim/CoinFlow#11: This PR's IntegrityAssertions validates WalletLedger consistency and specific ledger entry types, directly extending the wallet ledger domain and API implementation in PR #11.

Poem

🐰 A rabbit hops through tests so bright,
Integrity checks left, right, and tight!
Orders, wallets, ledgers aligned,
No broken state left behind! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly describes the main change: adding Phase 1 MVP integrity verification tests.
Linked Issues check	✅ Passed	All primary objectives from issue #34 have been implemented: integrity assertions utility [#34-1], test enhancements for orders/wallets/ledgers [#34-2], settlement/matching tests [#34-3], orderbook recovery tests [#34-4], concurrency tests [#34-5], and load verification with 3-minute k6 soak test results [#34-7].
Out of Scope Changes check	✅ Passed	All changes are directly aligned with issue #34 objectives: test utilities, test enhancements, and documentation of validation results. No infrastructure, Kafka, WebSocket, Redis, or architecture changes are present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/34/phase1-mvp-integrity-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}