Describe the task
While the Georeferencer class has been updated to handle the 4-parameter helmert transformation, the logic that converts georeferencing information into IIIF Georef AnnotationPage still has some bespoke transformation handling in it that needs to be updated.
In
|
transformer = gdal.Transformer( |
a standalone Transformer object is created which is then used to convert region boundary coords (because in OIM these are stored in pixel/line space). This transformer needs to be created with options that mimic those that are used to generate the Helmert params.
Completion criteria
It would be best to refactor that into a new method on Georeferencer called _get_transformer(), and potentially consolidate a bit of the logic that is already used to conditionally handle different transformations.
Additional context
Just looking at the current code, I'm not sure that it would properly handle thin plate spline transformations either, looks to be hard-coded for polynomial 1.
Describe the task
While the Georeferencer class has been updated to handle the 4-parameter helmert transformation, the logic that converts georeferencing information into IIIF Georef AnnotationPage still has some bespoke transformation handling in it that needs to be updated.
In
OldInsuranceMaps/ohmg/extensions/iiif.py
Line 53 in 9be55a4
Completion criteria
It would be best to refactor that into a new method on Georeferencer called _get_transformer(), and potentially consolidate a bit of the logic that is already used to conditionally handle different transformations.
Additional context
Just looking at the current code, I'm not sure that it would properly handle thin plate spline transformations either, looks to be hard-coded for polynomial 1.