Experimental support for compiling grammars to Wasm #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces experimental support for compiling grammars to WebAssembly by adding a new package and updating various dependency versions across the repository.
- Introduces the new package "wasm" with a WasmMatch class for grammar matching via WebAssembly.
- Upgrades AVA from version ^4.3.3 to ^6.0.0 in multiple packages and examples to ensure consistency and leverage new test capabilities.
- Adds AVA configuration in packages/ohm-js to improve test watch behavior.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/wasm/package.json | Added new package with basic configuration; consider populating the description field. |
| packages/ohm-js/package.json | Upgraded AVA version and added new AVA watchMode configuration. |
| packages/cli/package.json | Upgraded AVA version in the devDependencies. |
| examples/typescript/package.json | Upgraded AVA version for consistency in testing. |
| examples/simple-lisp/package.json | Upgraded AVA version for consistency in testing. |
| examples/operators/package.json | Upgraded AVA version for consistency in testing. |
| examples/markdown/package.json | Upgraded AVA version for consistency in testing. |
| examples/ecmascript/package.json | Upgraded AVA version for consistency in testing and added AVA configuration. |
Files not reviewed (1)
- packages/es-grammars/package-lock.json: Language not supported
| { | ||
| "name": "wasm", | ||
| "version": "1.0.0", | ||
| "description": "", |
There was a problem hiding this comment.
[nitpick] Consider providing a meaningful description for the wasm package to better communicate its purpose and functionality to users and potential contributors.
Suggested change
| "description": "", | |
| "description": "A package for working with WebAssembly (Wasm), including emitting and processing Wasm modules.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for WebAssembly, as describe in #503.
Adds a new package which exposes a
WasmMatchclass. Internally,WasmMatchercompiles the grammar to a WebAssembly module that exports amatchmethod.Working so far:
Not yet: