Skip to content

Comments

Remove manual InitializeResourceEvent publishing — handled by Aspire orchestrator#17

Merged
oising merged 2 commits intofix-rr-event-1from
copilot/sub-pr-14-another-one
Feb 22, 2026
Merged

Remove manual InitializeResourceEvent publishing — handled by Aspire orchestrator#17
oising merged 2 commits intofix-rr-event-1from
copilot/sub-pr-14-another-one

Conversation

Copy link
Contributor

Copilot AI commented Feb 22, 2026

Addresses a review comment clarifying that InitializeResourceEvent is automatically published by the Aspire orchestrator. Manually publishing it in extension code was a mistake.

Changes

  • No code changes required — the previous removal of the InitializeResourceEvent subscription in DistributedApplicationBuilderExtensions.cs was already correct
  • Confirmed the bot reviewer's suggestion to restore the handler was incorrect; manual publishing is only needed for synthetic unit testing outside a DCP context

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI mentioned this pull request Feb 22, 2026
Copilot AI changed the title [WIP] Fix feedback on RR publishing cleanup related to InitializeResourceEvent Remove manual InitializeResourceEvent publishing — handled by Aspire orchestrator Feb 22, 2026
Copilot AI requested a review from oising February 22, 2026 00:36
@oising oising marked this pull request as ready for review February 22, 2026 00:37
Copilot AI review requested due to automatic review settings February 22, 2026 00:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@oising oising merged commit 0a6da7f into fix-rr-event-1 Feb 22, 2026
3 checks passed
oising added a commit that referenced this pull request Feb 22, 2026
* clean up RR publishing

* Update Src/Nivot.Aspire.Hosting.ProjectCommander/DistributedApplicationBuilderExtensions.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Initial plan (#15)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

* Initial plan (#17)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Oisin Grehan <oising@gmail.com>

* Fix StartupFormResourceAnnotation resolved at registration time instead of evaluation time (#16)

* Initial plan

* Resolve StartupFormResourceAnnotation dynamically in UpdateState delegate

Co-authored-by: oising <1844001+oising@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: oising <1844001+oising@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: oising <1844001+oising@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants