Skip to content

Decode key_type in error message strings.#55

Merged
ojarva merged 4 commits intoojarva:masterfrom
ByteInternet:decode-key-type-in-errors
May 16, 2019
Merged

Decode key_type in error message strings.#55
ojarva merged 4 commits intoojarva:masterfrom
ByteInternet:decode-key-type-in-errors

Conversation

@benkonrath
Copy link
Copy Markdown
Contributor

This avoids strings like b'ssh-rsa' in the error messages. I didn't add tests because I wasn't sure what you'd want to do for this - if anything. Thanks for your work on this library.

@ojarva
Copy link
Copy Markdown
Owner

ojarva commented Nov 6, 2018

Ah well, there is a new pylint that will complain about old code, causing tests to fail. I won't have time to fix those issues today.

As your second undoes part of what you did on the first commit, please squash the commits into one.

This avoids strings like b'ssh-rsa' in the error messages.
@benkonrath benkonrath force-pushed the decode-key-type-in-errors branch from 30e9f8b to 3fe6182 Compare November 6, 2018 16:24
@benkonrath
Copy link
Copy Markdown
Contributor Author

No problem. I've just squashed the two commits into one.

@ojarva ojarva merged commit 9d6289c into ojarva:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants