fix: Show empty days in Work Log weekly view#24
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce30a93f2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const visibleWorkLogGroups = $derived( | ||
| buildRecentWorkLogGroups( | ||
| workLogs, | ||
| relativeTimeNowMs, | ||
| RECENT_WORK_LOG_DAY_COUNT, | ||
| ), | ||
| ); |
There was a problem hiding this comment.
Keep keyboard selection within visible recent logs
Because the rendered list is now derived from the moving seven-day window while workLogs itself is never pruned or reloaded as relativeTimeNowMs advances, leaving the app open across midnight can drop the previously selected oldest-day log from these groups while selectedWorkLogId still points at it. In that state the UI shows no selected row, and keyboard edit/navigation can continue to target an invisible log from outside the displayed week; the selection should be reconciled against the visible groups/logs when this derived window changes.
Useful? React with 👍 / 👎.
Summary
No logfor days without entriesChecks