libvirt guide: fix requirement links#112
Merged
vrutkovs merged 1 commit intookd-project:masterfrom May 26, 2020
Merged
Conversation
Contributor
|
Do the ha proxy / dns instructions need to be nested in the vsphere dir? If that's intentional than LGTM. |
Member
Author
|
It mostly due to "historical reasons" - originally these prerequisites were written for vSphere deploy, so I guess they should stay there - and other guides could refer to them if required. I'd rather not move them one dir higher so they would not be treated as a hard requirement - and we could have more setups described. However I have no hard feelings about this - if anyone suggests a better place for prereqs I'll gladly move them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.