Preserve query params with onLoad guard #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denysoblohin-okta
force-pushed
the
of-fix-query-onLoad-OKTA-521161
branch
from
d4d7ca3 to
bb7394a
Compare
denysoblohin-okta
force-pushed
the
of-fix-query-onLoad-OKTA-521161
branch
2 times, most recently
from
e0e4fbb to
7926bfe
Compare
Comment on lines
86
to
89
| // Passing function produces 'Error: Runtime compiler is not loaded' for prod build. Passing string fixes the issue. | ||
| // See https://github.com/angular/angular-cli/issues/10582 | ||
| loadChildren: () => import('./lazy-load/lazy-load.module').then(mod => mod.LazyLoadModule), | ||
| //loadChildren: './lazy-load/lazy-load.module#LazyLoadModule', |
Contributor
Author
There was a problem hiding this comment.
Passing function produces Error: Runtime compiler is not loaded for prod build for Angular 7.
Passing string fixes the issue.
See angular/angular-cli#10582
test/e2e/util/waitUtil.js
Outdated
Comment on lines
13
to
14
| console.log('[DEBUG] Console: ', await browser.getLogs('browser')); | ||
| console.log('[DEBUG] Body: ', body); |
Contributor
Author
There was a problem hiding this comment.
Added debug to catch errors like Error: Runtime compiler is not loaded above
trigger error . . .
denysoblohin-okta
force-pushed
the
of-fix-query-onLoad-OKTA-521161
branch
from
7926bfe to
87f5790
Compare
jaredperreault-okta
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #97
Internal ref: https://oktainc.atlassian.net/browse/OKTA-521161
onLoadguard should not get redirect URL fromsegmentsas it does not have query params. Insteadrouter.getCurrentNavigation()should be used.