Skip to content

fix: resolve Node compile issue, use nightly formatting, pin Rust to 1.93, and fix Claude 401s#198

Merged
louisliu2048 merged 6 commits intomainfrom
vui-chee/fixes-main
Mar 16, 2026
Merged

fix: resolve Node compile issue, use nightly formatting, pin Rust to 1.93, and fix Claude 401s#198
louisliu2048 merged 6 commits intomainfrom
vui-chee/fixes-main

Conversation

@Vui-Chee
Copy link
Contributor

@Vui-Chee Vui-Chee commented Mar 16, 2026

  • fix compile issue on node
  • set nightly formatting for just format
  • pin rust toolchain version
  • fix 401 issue on claude step
  • use rust 1.93

@Vui-Chee Vui-Chee marked this pull request as ready for review March 16, 2026 06:51
@Vui-Chee
Copy link
Contributor Author

Code Review: fix: addr compile issue on main

Summary: Fixes a compile error from the Reth v1.10.2 → v1.11.0 upstream upgrade — task_executor() method was removed in favor of direct field access (.task_executor). Also switches justfile formatting to cargo +nightly fmt and removes the unnecessary id-token: write permission from the top-level Claude workflow.


Issues

🟡 WarningCLAUDE.md docs are stale after the justfile change

CLAUDE.md still documents:

just check-format   # Check formatting (cargo fmt --all -- --check)

But check-format now calls cargo +nightly fmt --all -- --check. Should be updated to reflect the nightly requirement.

🟡 Warningid-token: write still present in claude-review job

The top-level workflow permissions had id-token: write removed (good, least-privilege), but the claude-review job at line 78 of .github/workflows/claude.yml still declares it as a job-level override. If OIDC auth isn't needed there, remove it for consistency.

🔵 Suggestion — Nightly toolchain not pinned

cargo +nightly fmt uses whatever nightly is installed locally/on CI. Consider pinning via rust-toolchain.toml to prevent format churn across different nightly versions.


Positives

  • Surgical fix: The Rust change is a single targeted field access correction — no logic touched.
  • Correct diagnosis: Directly addresses the upstream breaking change.
  • Least-privilege improvement: Removing id-token: write from the top-level workflow is the right call.

Verdict: LGTM — the core compile fix is correct. The warnings above are non-blocking.

@Vui-Chee Vui-Chee requested a review from JimmyShi22 March 16, 2026 07:05
@Vui-Chee Vui-Chee changed the title fix: addr compile issue on main fix: resolve Node compile issue, use nightly formatting, pin Rust to 1.93, and fix Claude 401s Mar 16, 2026
@louisliu2048 louisliu2048 merged commit d367361 into main Mar 16, 2026
2 of 3 checks passed
@Vui-Chee Vui-Chee deleted the vui-chee/fixes-main branch March 16, 2026 07:34
Vui-Chee added a commit that referenced this pull request Mar 17, 2026
* main:
  fix(claude): dup comments @review and unwarranted auth step trigger (#202)
  feat(intercept): add bridge intercept in flashblocks (#177)
  add github token to claude step (#201)
  restore id-token (#200)
  fix: resolve Node compile issue, use nightly formatting, pin Rust to 1.93, and fix Claude 401s (#198)
  feat: integrate legacy migrate tool into bin/tools crate (#196)
  refactor(node): clean up main.rs (#187)
  feat(ci): restrict to PR author as triggerman (#195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants