fix(legacy-rpc): eth_getLogs by blockHash returns empty array for local blocks with no matching events

[JimmyShi22]

Previously, querying eth_getLogs with a blockHash filter would forward to legacy if the local result was empty. This caused "block not found" errors when the block existed locally but had no matching events, since legacy doesn't hold those blocks.

Fix: check block existence via eth_getBlockByHash before deciding routing.

• Block found locally → return local result directly (even if logs are [])
• Block not found locally → forward to legacy

Also adds unit tests for all three routing branches and an e2e regression test covering both the empty-logs case and a block with ERC20 Transfer events.

[JimmyShi22]

@claude review this

[XLayer-Bot]

The fix is correct and well-targeted. Root cause analysis is accurate: the old is_result_empty check could not distinguish "empty logs for a local block" from "block unknown locally", causing unnecessary forwards to legacy that returned "block not found". Checking block existence first via eth_getBlockByHash cleanly resolves the ambiguity.

What I checked

• Routing logic for all three BlockHash branches (block found + empty logs, block found + events, block not found)
• call_eth_get_block_by_hash return type semantics: Ok(Some(_)) correctly signals "block exists locally" — all valid Ethereum blocks carry a parseable number field, so using it as an existence proxy is sound
• Hash validation coverage — parse_eth_get_logs_params validates via is_valid_32_bytes_string before producing GetLogsParams::BlockHash, so no invalid hash can reach call_eth_get_block_by_hash
• Unit tests cover all three routing branches with a clean mock; e2e test covers the regression case and ERC20 log retrieval
• The .omc gitignore entry is unrelated to the fix; fine to include but could be a separate commit

One minor note left inline.

workflow run

[JimmyShi22]

@claude pls review again

[XLayer-Bot]

The fix looks correct and complete. The previous concern about the silent arm has been addressed — the branch now logs the unexpected error before forwarding to legacy. The routing logic is semantically cleaner: block existence is checked first, and the empty-log case for a locally-known block is handled correctly. The three new unit tests cover all branches (block found with empty logs, block found with logs, block not found), and the e2e test adds regression coverage against a live node. workflow run

[louisliu2048]

@claude review this pr

[XLayer-Bot]

The fix is correct and complete.

Root cause & fix: The old BlockHash path checked is_result_empty on the eth_getLogs result to decide routing — forwarding to legacy whenever logs were []. A local block with zero matching events returns [], so it was incorrectly forwarded to a legacy endpoint that does not hold local blocks, producing a spurious "block not found" error. The new path checks block existence via eth_getBlockByHash first: if the block is local, return the local logs result unconditionally (even []); if the block is not found locally, forward to legacy.

Code review:

• The is_result_empty import is correctly removed from get_logs.rs and the function still exists and is used in service.rs for other routing paths.
• call_eth_get_block_by_hash calls self.inner.call(…) where self.inner is the raw RPC handler, not another LegacyRpcRouterService — no recursive routing risk.
• The Err(_) arm is correctly unreachable (hash already validated by is_valid_32_bytes_string in parse_eth_get_logs_params), and it falls back to legacy with a debug! log — good defensive coding.
• Unit tests cover all three routing branches. The "forwards to legacy" test correctly verifies the forward path by relying on a connection failure to the unreachable endpoint 127.0.0.1:1.
• E2E regression test covers both the empty-logs and non-empty-logs local cases.
• Flashblocks test fix (0x1 → current block with out-of-range index) is correct.

Both previously raised threads have been properly addressed.

workflow run

[XLayer-Bot]

🔧 CI running — workflow run

[XLayer-Bot]

✅ XLayer Reth CI passed for commit 0f712fd665a0d0f65dc6b6c317bbc0ba530d371a

Step	Result
format-check	✅ success
compile-check	✅ success
clippy	✅ success
tests	✅ success

View run