Skip to content

Conversation

@olekenneth
Copy link
Owner

@olekenneth olekenneth commented Oct 23, 2020

A perfect description

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pull requests have a body description that tells other contributors about the change you're suggesting, so they understand the context.

Let's edit this pull request to add a body description.

⌨️ Activity: Fixing your pull request

  1. The first comment on your pull request will have the default text of No description provided. Click on the ... icon located at the top right corner of the comment box, then click on Edit to make an edit
  2. Add a description of the changes you've made in the comment box. Feel free to add a description of what you’ve accomplished so far. As a reminder, you have: created a branch, created a file and made a commit, and opened a pull request
  3. Click the green Update comment button at the bottom right of the comment box when done

If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.


I'll respond when I detect this pull request's body has been edited.

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pull requests have a body description that tells other contributors about the change you're suggesting, so they understand the context.

Let's edit this pull request to add a body description.

⌨️ Activity: Fixing your pull request

  1. The first comment on your pull request will have the default text of No description provided. Click on the ... icon located at the top right corner of the comment box, then click on Edit to make an edit
  2. Add a description of the changes you've made in the comment box. Feel free to add a description of what you’ve accomplished so far. As a reminder, you have: created a branch, created a file and made a commit, and opened a pull request
  3. Click the green Update comment button at the bottom right of the comment box when done

If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.


I'll respond when I detect this pull request's body has been edited.

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting your file to be named _posts/0000-01-02-olekenneth.md.

Let's edit this pull request to fix both of these issues.

⌨️ Activity: Fixing your pull request

  1. Click the Files Changed tab in this pull request.
  2. Verify that the only file edited is named _posts/0000-01-02-olekenneth.md.
  3. If the file is improperly named, or not in a proper location, use the edit function to correct it.
  4. Above the contents of the file, select all text in the field that contains the filename and delete it.
  5. Continue pressing your backspace key to also delete any directory names that exist.
  6. Type the proper filename:
    _posts/0000-01-02-olekenneth.md
  7. Scroll to the bottom and enter a commit message and commit in the Commit Changes section.

Note: Can't find the button to edit the file? It may look like a pencil, or it may look like three dots.

If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.


I'll respond below when I detect a commit on this branch.

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 7: Respond to a review

Your pull request is looking great!

Let’s add some content to your file. Replace line 5 of your file with a quotation or meme and witty caption. Remember: Markdown is supported.

⌨️ Activity: Change your file

  1. Click the Files Changed tab in this pull request
  2. Edit your newly added file
  3. Replace line 5 with something new
  4. Scroll to the bottom and click Commit Changes

Note : Can't find the button to edit the file? It may look like a pencil, or it may look like three dots.


I'll respond when I detect a commit on this branch.

@olekenneth
Copy link
Owner Author

LGTM 👍

Copy link
Owner Author

@olekenneth olekenneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough

@@ -0,0 +1 @@
test
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something new

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 8: Merge your pull request

Nicely done @olekenneth! ✨

You successfully created a pull request, and it has passed all of the tests. You can now merge your pull request.

⌨️ Activity: Merge the pull request

  1. Click Merge pull request

  2. Click Confirm merge

  3. Once your branch has been merged, you don't need it anymore. Click Delete branch.


I'll respond when this pull request is merged.

@olekenneth olekenneth merged commit 1462a02 into master Oct 23, 2020
@github-learning-lab
Copy link

Nice work

celebrate

Congratulations @olekenneth, you've completed this course!

What went well

Now, you have your slide deck deployed here and you've gone through the GitHub Flow.

Before I say good-bye, here's a recap of all the tasks you've accomplished in your repository:

  • You learned about issues, pull requests, and the structure of a GitHub repository
  • You learned about branching
  • You created a commit
  • You viewed and responded to pull request reviews
  • You edited an existing file
  • You enabled GitHub Pages
  • You made your first contribution! 🎉

Give us feedback

We'd love to hear what you thought of this course. Please share your feedback in this brief survey.

What's next?

We hope this course helped you feel more comfortable using GitHub. Remember: You’re always welcome to repeat course topics if you’d like additional practice. If you’re ready to build on your new skills, here are some ideas.

Contribute to a project

To find projects to contribute to through trending topics and curated collections, check out GitHub Explore.

Keep learning

Here are some suggestions for future courses you can take:

  • GitHub Pages: Continue learning about GitHub Pages, which we touched on in this course.
  • Communicating using Markdown: We used a little Markdown in this course, but if you want to learn all about this ✨ syntax, take the course!

What will you learn next?

@olekenneth olekenneth deleted the olekenneth-patch-1 branch October 23, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants