added cameraPosition function#189
Merged
Merged
Conversation
olexale
reviewed
Jul 19, 2022
Owner
olexale
left a comment
olexale
left a comment
There was a problem hiding this comment.
Awesome! Thank you for this contribution!
Please change cameraPosition just a bit and I'll be happy to push a new version with these changes 👍
Comment on lines
+745
to
+747
| final result = await _channel.invokeMethod('cameraPosition'); | ||
| if(result != null) { | ||
| return _vector3Converter.fromJson(result!); |
Owner
There was a problem hiding this comment.
_vector3Converter.fromJson expects a List, hence please use invokeListMethod.
Dart is smart enough not to make you force unwrap the result.
So that could be:
final result = await _channel.invokeListMethod('cameraPosition');
if(result != null) {
return _vector3Converter.fromJson(result);Would you please try it to check whether it still works?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a native function that return camera position as Vector3