Skip to content

Conversation

@alireza1371
Copy link

better to use kubernetes_pod_name as instanse in setting variable.

better to use kubernetes_pod_name as instanse in setting variable.
@mohsenmottaghi
Copy link

It`s a good idea 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.379% when pulling 059226d on alireza1371:patch-1 into c3213a1 on oliver006:master.

@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #322 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #322   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files           2        2           
  Lines         828      828           
=======================================
  Hits          647      647           
  Misses        148      148           
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3213a1...059226d. Read the comment docs.

@oliver006
Copy link
Owner

This change (using kubernetes_pod_name instead of instance) would work for Kubernetes setups only and break for everyone else.
I think a better way to address this would be to either add a note to the docs regarding the dashboard or create a second, k8s-only dashboard (but then we'd need to keep two dashboards updated in case something changes).

@oliver006
Copy link
Owner

Closing...

@oliver006 oliver006 closed this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants