Skip to content

Conversation

@justabaka
Copy link
Contributor

The hover tooltip is wrong as it sums up every value which it shouldn't be doing if we want to see a real command call counts. The tooltip type should be set to "individual" to fix the value stacking/summing up issue.

Wrong tooltip:
image

Correct tooltip:
image

The hover tooltip is wrong as it sums up every value which it shouldn't be doing if we want to see a real command call counts. The tooltip type should be set to "individual" to fix the value stacking/summing up issue.

Wrong tooltip:
![image](https://user-images.githubusercontent.com/416302/67585468-c6cdf280-f779-11e9-9eff-a7cb14913a63.png)

Correct tooltip:
![image](https://user-images.githubusercontent.com/416302/67585357-938b6380-f779-11e9-9148-53e7e9a8e587.png)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.379% when pulling 56aaf04 on justabaka:master into c3213a1 on oliver006:master.

@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files           2        2           
  Lines         828      828           
=======================================
  Hits          647      647           
  Misses        148      148           
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3213a1...56aaf04. Read the comment docs.

@oliver006
Copy link
Owner

Thank for the PR, looks good!

@oliver006 oliver006 merged commit 958cf21 into oliver006:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants