Minor dissapearing cursor bug fix and some code cleanup for BW Lua

[brad112358]

Since the number of cursor index positions is now the same for all pages except the info page, we can eliminate some of the ugly special case code associated with page 0. Also, reduce the options on the info page to just "Next" which returns to page 0. Bonus: This should use just a tad less memory.

Tested and compiled on EdgeTx version 2.11.4.

@jlpoltrack, perhaps you can give this a quick look and test. Thanks!

[olliw42]

great. THX. When tested by @jlpoltrack he can merge.

Question: The "ugly" special code may not have to come back at some later point?
I mean, I don't understand exactly what this is about, so can't form my own opinion, but wonder if "number of cursor index positions is now the same for all pages except the info page" is a very special constellation currently arrising by accident or is the natural state of affairs?

[brad112358]

Question: The "ugly" special code may not have to come back at some later point?
I mean, I don't understand exactly what this is about, so can't form my own opinion, but wonder if "number of cursor index positions is now the same for all pages except the info page" is a very special constellation currently arrising by accident or is the natural state of affairs?

Yes, it is a happy coincidence. If we add or delete a cursor position on page 0, but not on the other pages, we will need a possibly different adjustment. I believe the color Lua has a different function for the initial page, but in the name of smaller code, I ended up with a bit of a mess which I'm happy to be able to reduce now, even if I have to put it back later.

[olliw42]

great.
tried to run it on my t16 with color display but it emergency moded ... not sure how that one user could see iit on his radio. LOL.
when JLP has tested he can merge. LGTM.

[jlpoltrack]

@brad112358 this works fine for me on GX12. One minor suggestion - can you share the EdgeTx version that you used for the compiled version just for reference in the first comment of the PR?

[brad112358]

I've edited the first comment. Since you mention it, do we know of any version related Luac incompatibility issues yet?

[jlpoltrack]

I've edited the first comment. Since you mention it, do we know of any version related Luac incompatibility issues yet?

I do not - I think EdgeTx is changing Lua version in 3.x, so good to have for reference.