Skip to content

Bump electron from 34.0.0 to 39.8.5#5

Closed
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/electron-39.8.5
Closed

Bump electron from 34.0.0 to 39.8.5#5
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/electron-39.8.5

Conversation

@dependabot
Copy link
Copy Markdown

@dependabot dependabot Bot commented on behalf of github Apr 30, 2026

Bumps electron from 34.0.0 to 39.8.5.

Release notes

Sourced from electron's releases.

electron v39.8.5

Release Notes for v39.8.5

Fixes

  • Fixed a crash in clipboard.readImage() when the clipboard contains malformed image data. #50493 (Also in 40, 41, 42)
  • Fixed a crash when calling an offscreen shared texture's release() after the texture object was garbage collected. #50499 (Also in 40, 41, 42)

electron v39.8.4

Release Notes for v39.8.4

Fixes

  • Fixed an issue where nodeIntegrationInWorker overrides in setWindowOpenHandler were not honored for child windows sharing a renderer process with their opener. #50468 (Also in 38, 40, 41)
  • Fixed crash when handling JavaScript dialogs from windows opened with invalid or empty URLs. #50400 (Also in 40, 41, 42)
  • Fixed improper focus tracking in BaseWindow on MacOS. #50338 (Also in 40, 41, 42)
  • Fixed window freeze when failing to enter/exit fullscreen on macOS. #50341 (Also in 40, 41, 42)

Other Changes

  • Added support for using a proxy during yarn install. #50349 (Also in 40, 41, 42)
  • Backported fix for 485935305. #50440
  • Backported fix for 489381399. #50443
  • Backported fix for chromium:475877320. #50436
  • Backported fixes for 484751092, 487117772. #50461

electron v39.8.3

Release Notes for v39.8.3

Fixes

  • Added additional ASAR support to additional fs copy methods. #50284 (Also in 40, 41, 42)
  • Fixed user resizing of transparent windows on win32 platform. #50300 (Also in 40, 41, 42)

electron v39.8.2

Release Notes for v39.8.2

Other Changes

  • Backported fix for b/491421267. #50230

electron v39.8.1

Release Notes for v39.8.1

Fixes

  • Added validation to protocol client methods to reject protocol names that do not conform to the RFC 3986 URI scheme grammar. #50156 (Also in 38, 40, 41)
  • Fixed an issue on macOS where calling autoUpdater.quitAndInstall() could fail if checkForUpdates() was called again after an update was already downloaded. #50215 (Also in 40, 41)
  • Fixed an issue where Chrome Devtools menus may not appear in certain embedded windows. #50136 (Also in 40, 41)
  • Fixed an issue where additionalData passed to app.requestSingleInstanceLock on Windows could be truncated or fail to deserialize in the primary instance's second-instance event. #50174 (Also in 38, 40, 41)
  • Fixed an issue where screen.getCursorScreenPoint() crashed on Wayland when it was called before a BrowserWindow had been created. #50106 (Also in 40, 41)

... (truncated)

Commits
  • 9d2f8cb refactor: remove dead named-window lookup from guest-window-manager (#50498)
  • 1173004 fix: crash calling OSR shared texture release() after texture GC'd (#50499)
  • be37ade fix: crash in clipboard.readImage() on malformed image data (#50493)
  • 7007907 chore: cherry-pick 3 changes from chromium (#50461)
  • 2c8b6ee chore: cherry-pick fbfb27470bf6 from chromium (#50436)
  • 4c64377 chore: cherry-pick 50b057660b4d from chromium (#50440)
  • 0ef0561 fix: read nodeIntegrationInWorker from per-frame WebPreferences (#50122) (#50...
  • 64373df chore: cherry-pick 074d472db745 from chromium (#50443)
  • 13e4407 fix: don't re-parse URL unnecessarily when handling dialogs (#50400)
  • 16a0385 ci: output build cache hit rate as GHA annotation (#50369)
  • Additional commits viewable in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Apr 30, 2026
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="package.json">

<violation number="1" location="package.json:32">
P1: Electron was bumped in devDependencies, but `build.electronVersion` is still pinned to 34.0.0, which can cause packaged builds to use the old Electron runtime.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread package.json
"@types/react-dom": "19.2.3",
"@vitejs/plugin-react": "5.2.0",
"electron": "31.0.0",
"electron": "39.8.5",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Electron was bumped in devDependencies, but build.electronVersion is still pinned to 34.0.0, which can cause packaged builds to use the old Electron runtime.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 32:

<comment>Electron was bumped in devDependencies, but `build.electronVersion` is still pinned to 34.0.0, which can cause packaged builds to use the old Electron runtime.</comment>

<file context>
@@ -29,7 +29,7 @@
     "@types/react-dom": "19.2.3",
     "@vitejs/plugin-react": "5.2.0",
-    "electron": "31.0.0",
+    "electron": "39.8.5",
     "electron-builder": "24.13.3",
     "electron-vite": "5.0.0",
</file context>

@dependabot dependabot Bot changed the title Bump electron from 34.0.0 to 39.8.5 Bump electron from 31.0.0 to 39.8.5 Apr 30, 2026
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/electron-39.8.5 branch from 326eabe to 796cd96 Compare April 30, 2026 10:29
@dependabot dependabot Bot changed the title Bump electron from 31.0.0 to 39.8.5 Bump electron from 34.0.0 to 39.8.5 Apr 30, 2026
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/electron-39.8.5 branch from 796cd96 to 016cefd Compare April 30, 2026 10:31
Bumps [electron](https://github.com/electron/electron) from 34.0.0 to 39.8.5.
- [Release notes](https://github.com/electron/electron/releases)
- [Commits](electron/electron@v34.0.0...v39.8.5)

---
updated-dependencies:
- dependency-name: electron
  dependency-version: 39.8.5
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/electron-39.8.5 branch from 016cefd to c483968 Compare April 30, 2026 10:35
@dependabot @github
Copy link
Copy Markdown
Author

dependabot Bot commented on behalf of github Apr 30, 2026

Looks like electron is up-to-date now, so this is no longer needed.

@dependabot dependabot Bot closed this Apr 30, 2026
@dependabot dependabot Bot deleted the dependabot/npm_and_yarn/electron-39.8.5 branch April 30, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants