Bump electron from 34.0.0 to 39.8.5#5
Closed
dependabot[bot] wants to merge 1 commit intomainfrom
Closed
Conversation
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="package.json">
<violation number="1" location="package.json:32">
P1: Electron was bumped in devDependencies, but `build.electronVersion` is still pinned to 34.0.0, which can cause packaged builds to use the old Electron runtime.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "@types/react-dom": "19.2.3", | ||
| "@vitejs/plugin-react": "5.2.0", | ||
| "electron": "31.0.0", | ||
| "electron": "39.8.5", |
There was a problem hiding this comment.
P1: Electron was bumped in devDependencies, but build.electronVersion is still pinned to 34.0.0, which can cause packaged builds to use the old Electron runtime.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 32:
<comment>Electron was bumped in devDependencies, but `build.electronVersion` is still pinned to 34.0.0, which can cause packaged builds to use the old Electron runtime.</comment>
<file context>
@@ -29,7 +29,7 @@
"@types/react-dom": "19.2.3",
"@vitejs/plugin-react": "5.2.0",
- "electron": "31.0.0",
+ "electron": "39.8.5",
"electron-builder": "24.13.3",
"electron-vite": "5.0.0",
</file context>
326eabe to
796cd96
Compare
796cd96 to
016cefd
Compare
Bumps [electron](https://github.com/electron/electron) from 34.0.0 to 39.8.5. - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v34.0.0...v39.8.5) --- updated-dependencies: - dependency-name: electron dependency-version: 39.8.5 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
016cefd to
c483968
Compare
Author
|
Looks like electron is up-to-date now, so this is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps electron from 34.0.0 to 39.8.5.
Release notes
Sourced from electron's releases.
... (truncated)
Commits
9d2f8cbrefactor: remove dead named-window lookup from guest-window-manager (#50498)1173004fix: crash calling OSR shared texture release() after texture GC'd (#50499)be37adefix: crash in clipboard.readImage() on malformed image data (#50493)7007907chore: cherry-pick 3 changes from chromium (#50461)2c8b6eechore: cherry-pick fbfb27470bf6 from chromium (#50436)4c64377chore: cherry-pick 50b057660b4d from chromium (#50440)0ef0561fix: read nodeIntegrationInWorker from per-frame WebPreferences (#50122) (#50...64373dfchore: cherry-pick 074d472db745 from chromium (#50443)13e4407fix: don't re-parse URL unnecessarily when handling dialogs (#50400)16a0385ci: output build cache hit rate as GHA annotation (#50369)