list skills: filter by olostep prefix#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
olostep list skillswas iterating every entry in the shared lockfile at~/.agents/.skill-lock.json. Because that file is shared with any other CLI that follows the agent-skills convention, leftover entries from previously-installed tools (e.g. an old install of another scraping CLI) leaked into our output — showing 42 "skills" instead of the 13 we actually manage.Fix: skip lockfile entries whose folder name doesn't start with
olostep-inlistInstalledSkills. The remove path already had this check;iterSkillEntries(used by removeAll) was already safe.Before
After
Test plan
src/lib/skills.test.tscovering: mixed lockfile, all-foreign lockfile, missing lockfile, olostep entry with missing canonical patholostep list skillson a machine with 29 foreign entries returns only 13 olostep ones