Allow apps to have any type of user_id field.#1040
Closed
prmtl wants to merge 1 commit intoomab:masterfrom
Closed
Conversation
This is the same as it was done for Pyramid app - do not expect that User.id will be always an Integer but get it's type and use it in UserSocialAuth.user_id column.
1078c07 to
de9f179
Compare
Owner
|
I've ported this PR into social-app-flask-sqlalchemy, social-app-pyramid, social-app-tornado and social-app-webpy. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as it was done for Pyramid app - do not
expect that User.id will be always an Integer but get it's
type and use it in UserSocialAuth.user_id column.