/python-social-auth

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid passing bytes to string format in header #947

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@EdwardBetts
@EdwardBetts
Contributor

EdwardBetts commented Jul 13, 2016

Using Python 3, we need to pass a str to format, not bytes. Otherwise we end up with an Authorization that looks like:

Authorization: Basic b'Zm9vOmJhcg=='
@EdwardBetts
Avoid passing bytes to string format in header 
Using Python 3, we need to pass a str to format, not bytes. Otherwise we end up with an Authorization that looks like:

Authorization: Basic b'Zm9vOmJhcg=='
07d6fb1
@EdwardBetts

This comment has been minimized.

Show comment
Hide comment
@EdwardBetts

EdwardBetts Jul 13, 2016

Contributor

This affects more backends. I've submitted a new pull request: #947.
Contributor

EdwardBetts commented Jul 13, 2016

This affects more backends. I've submitted a new pull request: #947.

@EdwardBetts EdwardBetts closed this Jul 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment