Avoid passing bytes to string format in header#947
Closed
EdwardBetts wants to merge 1 commit intoomab:masterfrom
Closed
Avoid passing bytes to string format in header#947EdwardBetts wants to merge 1 commit intoomab:masterfrom
EdwardBetts wants to merge 1 commit intoomab:masterfrom
Conversation
Using Python 3, we need to pass a str to format, not bytes. Otherwise we end up with an Authorization that looks like: Authorization: Basic b'Zm9vOmJhcg=='
Contributor
Author
|
This affects more backends. I've submitted a new pull request: #947. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Python 3, we need to pass a str to format, not bytes. Otherwise we end up with an Authorization that looks like:
Authorization: Basic b'Zm9vOmJhcg=='