Repository navigation
Check network connectivity before omarchy-update starts making changes
#13333
lavrinovich86
started this conversation in
Suggestions
Replies: 1 comment
|
This seems worth catching before the snapshot/cache work. I would avoid a generic “internet is up” check though, because a successful ping doesn't tell us whether the endpoints the updater actually needs are reachable. A cheap DNS lookup for the Omarchy package host plus one Arch mirror would cover the failure shown here. If that fails, exit with something explicit like “network/DNS not ready; no changes made.” Then the existing package operations remain the real authority once the preflight passes. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
What happened
I ran
omarchy-updateabout 30 seconds after boot. Wi-Fi had associated with the access point, but DHCP had not yet handed out an address. The update still pruned the package cache, took a Snapper snapshot, and started the stay-awake inhibitor before it reachedomarchy-update-keyring, wherepacman -Syfailed:The journal shows the timing:
The root cause was on my network, not in Omarchy. But the update left behind a snapshot for an update that never ran, and the only message was a generic "Something went wrong" with a red
setpriv terminated by signal TERMline that looks like a crash. That line appears to come from the stay-awake inhibitor being stopped during cleanup.Suggestion
Add a network preflight next to
omarchy-update-requires-free-space, beforeomarchy-update-pkg-pruneandomarchy-snapshot create. For example, anomarchy-update-requires-networkscript that:omarchy-network-statusalready usesip route get 1.1.1.1).getent hosts mirror.omarchy.org).nm-online -s -q -t 30) for an interface that is still activating.OMARCHY_UPDATE_FORCE=1like the free-space check does.This would stop before any snapshot or cache change and show the actual reason. It also covers captive portals, VPN switches and early-boot races.
Related: #12455 proposes a download/apply split for connections that drop mid-update. This suggestion is narrower: it covers the case where there is no connection at the start.
A smaller, separate improvement: hide or reword the
setpriv terminated by signal TERMline on the failure path, since it is expected cleanup and not an error.System
4.0.0.r2304.g7b336b1-17.2.5-4-omarchyFiled by Claude Opus 5.5 via Claude Code.
All reactions