fix(cluster): include registry_password in Create/UpdateClusterRequest

[omattsson]

Summary

CreateClusterRequest / UpdateClusterRequest in cli/pkg/types/types.go had registry_url, registry_username, and image_pull_secret_name but not registry_password. The backend has accepted it since the registry_password column was added in migration 0042 — stackctl just silently dropped it from the JSON body.

Any caller that needed to set ACR / private-registry pull credentials had to drop down to curl because the password fell out. The kvk-k8s-dev bootstrap (scripts/bootstrap-local.sh) and ACR-token refresh (scripts/refresh-acr-token.sh) both hit this and can't fully migrate off direct API calls until this lands.

Change

• Add RegistryPassword (string + *string in the update variant) to both request types, beside the existing url/username/pull-secret triple.
• Two new round-trip tests in client_test.go:
  • TestCreateCluster_RegistryCredentialsRoundTrip — asserts all 4 registry fields appear on POST /api/v1/clusters with snake_case keys.
  • TestUpdateCluster_RegistryCredentialsRoundTrip — same for PUT /api/v1/clusters/:id, plus a negative assertion that untouched pointer fields stay out of the body (verifies omitempty on pointers).

No CLI flag added — credentials should not be passed on the command line. Callers use cluster create --from-file / cluster update --from-file, matching the rest of the admin-payload pattern.

Test plan

• go vet ./... clean
• go test ./... full suite green
• Both new round-trip tests pass

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Added support for specifying registry password during cluster creation
  • Registry password can now be configured and updated for existing clusters

• Tests

  • Added test cases verifying registry credentials are correctly serialized during cluster operations
  • Tests ensure unrelated fields are not sent when not provided

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6bac0e88-52a7-461c-a67f-b3065b2d44e7

📥 Commits

Reviewing files that changed from the base of the PR and between a13f77d and 571504a.

📒 Files selected for processing (2)

• cli/pkg/client/client_test.go
• cli/pkg/types/types.go

---

📝 Walkthrough

Walkthrough

This PR adds support for registry password credentials in cluster creation and update operations. The RegistryPassword field is introduced to both CreateClusterRequest and UpdateClusterRequest types, enabling clients to specify or update registry authentication. Tests verify that these credentials serialize correctly into HTTP request bodies.

Changes

Registry Password Support

Layer / File(s)	Summary
Registry password type definitions cli/pkg/types/types.go	CreateClusterRequest gains a RegistryPassword string field; UpdateClusterRequest gains an optional RegistryPassword pointer field. Both use JSON/YAML tags for registry_password with omitempty.
Registry credentials serialization tests cli/pkg/client/client_test.go	TestCreateCluster_RegistryCredentialsRoundTrip and TestUpdateCluster_RegistryCredentialsRoundTrip stand up HTTP test servers to verify registry credentials (URL, username, password, image pull secret) serialize correctly, and that unrelated omitted fields are excluded from the request JSON.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding registry_password field to Create/UpdateClusterRequest types.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/cluster-registry-password

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}