[misc] fix incorrect integration path#179
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @carlory, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical build issue by fixing an incorrect file path within the Makefile. The integration-test target was failing to locate the test files, preventing the integration test suite from running. By updating the path, the make integration-test command will now execute as expected, ensuring the test suite can be properly run and verified.
Highlights
- Build Fix: I've corrected the path used for running integration tests in the
Makefile. Previously, theintegration-testtarget was looking for tests in./integration_tests/..., which caused a 'no such file or directory' error. This has been updated to the correct path,./tests/....
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This PR correctly fixes the path for the integration-test Makefile target. I've added one suggestion to also include the KUBEBUILDER_ASSETS environment variable, which is necessary for the envtest-based integration tests to run correctly. This will make the fix complete and ensure the integration tests can run successfully.
| integration-test: fmt vet manifests envtest ## 🧪 Run integration tests | ||
| @echo "🧪 Running integration tests..." | ||
| go test -v ./integration_tests/... -ginkgo.v -ginkgo.trace | ||
| go test -v ./tests/... -ginkgo.v -ginkgo.trace |
There was a problem hiding this comment.
This path correction is a good fix. However, for the integration tests to run correctly, they also need the KUBEBUILDER_ASSETS environment variable to be set. This variable points to the test control plane binaries managed by envtest.
Without this, the tests will likely fail to find the test environment. You can see this pattern used in the test target (lines 543, 553, 563). Applying the same logic here will ensure the integration-test target works as expected.
KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path)" go test -v ./tests/... -ginkgo.v -ginkgo.trace
|
Hi @slin1237, when I run the integration test, I got the following error: After I look at the ome-agent code, I can not find the training-agent command. Should I remove all related code https://github.com/search?q=repo%3Asgl-project%2Fome%20training-agent&type=code? |
yes please. Sorry I merged too fast. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?