Skip to content

[misc] fix incorrect integration path#179

Merged
slin1237 merged 1 commit into
ome-projects:mainfrom
carlory:fix-integration-test
Jul 14, 2025
Merged

[misc] fix incorrect integration path#179
slin1237 merged 1 commit into
ome-projects:mainfrom
carlory:fix-integration-test

Conversation

@carlory
Copy link
Copy Markdown
Contributor

@carlory carlory commented Jul 14, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

(base) ➜  ome git:(main) make integration-test
...
🧪 Running integration tests...
go test -v ./integration_tests/... -ginkgo.v -ginkgo.trace
# ./integration_tests/...
pattern ./integration_tests/...: lstat ./integration_tests/: no such file or directory
FAIL	./integration_tests/... [setup failed]
FAIL
make: *** [integration-test] Error 1
(base) ➜  ome git:(main)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@carlory carlory requested a review from slin1237 as a code owner July 14, 2025 09:56
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @carlory, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical build issue by fixing an incorrect file path within the Makefile. The integration-test target was failing to locate the test files, preventing the integration test suite from running. By updating the path, the make integration-test command will now execute as expected, ensuring the test suite can be properly run and verified.

Highlights

  • Build Fix: I've corrected the path used for running integration tests in the Makefile. Previously, the integration-test target was looking for tests in ./integration_tests/..., which caused a 'no such file or directory' error. This has been updated to the correct path, ./tests/....
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR correctly fixes the path for the integration-test Makefile target. I've added one suggestion to also include the KUBEBUILDER_ASSETS environment variable, which is necessary for the envtest-based integration tests to run correctly. This will make the fix complete and ensure the integration tests can run successfully.

Comment thread Makefile
integration-test: fmt vet manifests envtest ## 🧪 Run integration tests
@echo "🧪 Running integration tests..."
go test -v ./integration_tests/... -ginkgo.v -ginkgo.trace
go test -v ./tests/... -ginkgo.v -ginkgo.trace
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This path correction is a good fix. However, for the integration tests to run correctly, they also need the KUBEBUILDER_ASSETS environment variable to be set. This variable points to the test control plane binaries managed by envtest.

Without this, the tests will likely fail to find the test environment. You can see this pattern used in the test target (lines 543, 553, 563). Applying the same logic here will ensure the integration-test target works as expected.

	KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path)" go test -v ./tests/... -ginkgo.v -ginkgo.trace

@slin1237 slin1237 merged commit 113a0cf into ome-projects:main Jul 14, 2025
23 checks passed
@carlory
Copy link
Copy Markdown
Contributor Author

carlory commented Jul 14, 2025

Hi @slin1237, when I run the integration test, I got the following error:

• [FAILED] [8.109 seconds]
OME Agent Framework when running with --help flag [It] should display the root help information
/Users/kiki/workspace/golang/src/github.com/sgl-project/ome/tests/agent_integration_test.go:50

  [FAILED] Expected
      <string>: OME Agent is a swiss army knife for OME inference service, training job, model management, etc.

      Usage:
        ome-agent [command]

      Available Commands:
        completion         Generate the autocompletion script for the specified shell
        enigma             Run OME Enigma Agent
        fine-tuned-adapter Run OME fine-tuned adapter
        help               Help about any command
        hf-download        Run OME HuggingFace Download Agent
        model-metadata     Extract model metadata from PVC-mounted models
        replica            Run OME Object Storage Replica Agent
        serving-agent      Run OME serving sidecar

      Flags:
        -h, --help   help for ome-agent

      Use "ome-agent [command] --help" for more information about a command.

  to contain substring
      <string>: training-agent
  In [It] at: /Users/kiki/workspace/golang/src/github.com/sgl-project/ome/tests/agent_integration_test.go:69 @ 07/14/25 18:15:16.604

  Full Stack Trace
    github.com/sgl-project/ome/tests.init.func4.3.1()
    	/Users/kiki/workspace/golang/src/github.com/sgl-project/ome/tests/agent_integration_test.go:69 +0x598

After I look at the ome-agent code, I can not find the training-agent command. Should I remove all related code https://github.com/search?q=repo%3Asgl-project%2Fome%20training-agent&type=code?

@slin1237
Copy link
Copy Markdown
Collaborator

Hi @slin1237, when I run the integration test, I got the following error:


• [FAILED] [8.109 seconds]

OME Agent Framework when running with --help flag [It] should display the root help information

/Users/kiki/workspace/golang/src/github.com/sgl-project/ome/tests/agent_integration_test.go:50



  [FAILED] Expected

      <string>: OME Agent is a swiss army knife for OME inference service, training job, model management, etc.



      Usage:

        ome-agent [command]



      Available Commands:

        completion         Generate the autocompletion script for the specified shell

        enigma             Run OME Enigma Agent

        fine-tuned-adapter Run OME fine-tuned adapter

        help               Help about any command

        hf-download        Run OME HuggingFace Download Agent

        model-metadata     Extract model metadata from PVC-mounted models

        replica            Run OME Object Storage Replica Agent

        serving-agent      Run OME serving sidecar



      Flags:

        -h, --help   help for ome-agent



      Use "ome-agent [command] --help" for more information about a command.



  to contain substring

      <string>: training-agent

  In [It] at: /Users/kiki/workspace/golang/src/github.com/sgl-project/ome/tests/agent_integration_test.go:69 @ 07/14/25 18:15:16.604



  Full Stack Trace

    github.com/sgl-project/ome/tests.init.func4.3.1()

    	/Users/kiki/workspace/golang/src/github.com/sgl-project/ome/tests/agent_integration_test.go:69 +0x598

After I look at the ome-agent code, I can not find the training-agent command. Should I remove all related code https://github.com/search?q=repo%3Asgl-project%2Fome%20training-agent&type=code?

yes please. Sorry I merged too fast.
Thank you so much for fixing this

slin1237 pushed a commit that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants