Skip to content

[chore] update code owner#188

Merged
slin1237 merged 1 commit into
mainfrom
slin/codeowner
Jul 15, 2025
Merged

[chore] update code owner#188
slin1237 merged 1 commit into
mainfrom
slin/codeowner

Conversation

@slin1237
Copy link
Copy Markdown
Collaborator

No description provided.

@slin1237 slin1237 merged commit 19524bb into main Jul 15, 2025
15 checks passed
@slin1237 slin1237 deleted the slin/codeowner branch July 15, 2025 21:02
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the .github/CODEOWNERS file to reflect current code ownership. It adjusts the responsible parties for specific directories within the repository, ensuring that future pull requests affecting these paths will automatically request reviews from the correct individuals.

Highlights

  • Code Owner Removal: Removed @zhyncs from the list of code owners for the /config/ directory.
  • New Code Owner Assignment: Assigned @pallasathena92 as the code owner for the /pkg/runtimeselector directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CODEOWNERS file by removing one owner for the /config/ directory and adding a new owner for the /pkg/runtimeselector package. My review suggests sorting the package paths for better maintainability.

Comment thread .github/CODEOWNERS
Comment on lines 12 to 16
/pkg/controller/v1beta1/benchmark @CatherineSue
/pkg/runtimeselector @pallasathena92
/pkg/controller/v1beta1/inferenceservice @slin1237 @CatherineSue @YouNeedCryDear
/pkg/principals @slin1237 @pallasathena92 @speedmancs @chengjieyao @davidsnahm @heymrbox @frankzhouhr
/pkg/ociobjectstore @slin1237 @pallasathena92 @speedmancs @chengjieyao @davidsnahm @heymrbox @frankzhouhr
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and maintainability, it's a good practice to keep the entries in the CODEOWNERS file sorted alphabetically. The new entry for /pkg/runtimeselector is not in alphabetical order, and some existing entries are also out of order.

Consider sorting all entries under the # Core Go packages section.

/pkg/controller/v1beta1/benchmark   @CatherineSue
/pkg/controller/v1beta1/inferenceservice @slin1237 @CatherineSue @YouNeedCryDear
/pkg/ociobjectstore @slin1237 @pallasathena92 @speedmancs @chengjieyao @davidsnahm @heymrbox @frankzhouhr
/pkg/principals   @slin1237 @pallasathena92 @speedmancs @chengjieyao @davidsnahm @heymrbox @frankzhouhr
/pkg/runtimeselector @pallasathena92

slin1237 added a commit that referenced this pull request Jul 16, 2025
slin1237 added a commit that referenced this pull request Jul 16, 2025
slin1237 added a commit that referenced this pull request Jul 16, 2025
slin1237 added a commit that referenced this pull request Jul 16, 2025
slin1237 added a commit that referenced this pull request Dec 22, 2025
slin1237 added a commit that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant