[Bugfix]: verify KEDA ScaledObject CRD is registered before deletion

[bindrad]

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes a startup failure when deploying a model (I tried deepseek-r1) with HPA enabled but without optional components like KEDA. Previously, reconciler would immediately attempt to delete a ScaledObject, even if the KEDA API hadn’t been registered, resulting in a “not added to scheme” error and halting the reconcile loop. Now, the controller first checks whether the ScaledObject type is registered before deletion and cleanly skips ScaledObject cleanup when the API isn’t available, allowing reconciliation to proceed normally in environments without KEDA while preserving existing autoscaling behavior when it is installed.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

RawDeployment controller now verifies the KEDA ScaledObject CRD is registered before deletion

[gemini-code-assist]

Summary of Changes

Hello @bindrad, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug that caused the controller to fail during startup when KEDA (Kubernetes Event-driven Autoscaling) was not present in the cluster. The core change introduces a check to conditionally handle the cleanup of KEDA ScaledObject resources, aiming to ensure the controller can reconcile successfully in environments regardless of KEDA's installation status.

Highlights

• Bug Fix for KEDA Dependency: The deleteExistingScaledObject call, which previously ran unconditionally, is now wrapped in a conditional check. Specifically, it will attempt to delete an existing KEDA ScaledObject only if the KEDA API group (kedav1.SchemeGroupVersion.Group) is not registered with the scheme. This change aims to prevent startup failures when KEDA is not installed, as the original issue was a 'not added to scheme' error.
• Code Refinement: The clientset kubernetes.Interface parameter has been removed from the createAutoscaler function signature and its corresponding call site in NewAutoscalerReconciler, simplifying the function's dependencies.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix a startup failure by checking for KEDA's CRD registration before attempting to delete a ScaledObject. This is the correct approach to prevent reconciliation loops when KEDA is not installed.

I've identified a critical issue where the check's logic is inverted, which would prevent the fix from working as intended and could introduce new issues. My review includes a suggested correction for this logic. The other changes, like removing an unused clientset parameter, are good cleanups.