[Misc] Add more OCI instance types in instance_type_util

[beiguo218]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add more OCI instance types supported in instance_type_util

Does this PR introduce a user-facing change?

Model agent and model enigma would support more OCI instance types as added in this PR.

[gemini-code-assist]

Summary of Changes

Hello @beiguo218, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the instance_type_util package by incorporating additional Oracle Cloud Infrastructure (OCI) GPU instance types. This enhancement ensures that components like Model agent and Model enigma can correctly identify and support a broader range of OCI compute resources, specifically the newer H100 and H200 GPU instances, thereby improving compatibility and operational flexibility.

Highlights

• New OCI Instance Types: Added three new Oracle Cloud Infrastructure (OCI) GPU instance types: "BM.GPU.H100-NC.8", "BM.GPU.H200.8", and "BM.GPU.H200-NC.8" to the instanceTypeMap in pkg/utils/instance_type_util.go.
• Test Coverage: Included a new test case in pkg/utils/instance_type_util_test.go to validate the correct short name mapping for the BM.GPU.H200.8 instance type, ensuring it returns "H200".

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for new OCI instance types (BM.GPU.H100-NC.8, BM.GPU.H200.8, BM.GPU.H200-NC.8) by updating the instanceTypeMap. The change is straightforward and includes an update to the tests. My review focuses on improving test coverage to ensure all new instance types are validated. I've suggested adding test cases for the two new mappings that were not covered.

[gemini-code-assist]

It's great that you've added a test case for the H200 instance type. However, the changes in instance_type_util.go also introduce mappings for BM.GPU.H100-NC.8 and BM.GPU.H200-NC.8. To ensure full test coverage for the new additions, please consider adding test cases for these instance types as well.

		{
			name:         "OCI H200 instance",
			instanceType: "BM.GPU.H200.8",
			expected:     "H200",
			expectError:  false,
		},
		{
			name:         "OCI H100-NC instance",
			instanceType: "BM.GPU.H100-NC.8",
			expected:     "H100",
			expectError:  false,
		},
		{
			name:         "OCI H200-NC instance",
			instanceType: "BM.GPU.H200-NC.8",
			expected:     "H200",
			expectError:  false,
		},