Skip to content

(feat)(fix) Fix Qwen quantization parsing and add Qwen 3.5 model config tests#533

Merged
YouNeedCryDear merged 4 commits into
mainfrom
feat/qwen-runtimes
Mar 6, 2026
Merged

(feat)(fix) Fix Qwen quantization parsing and add Qwen 3.5 model config tests#533
YouNeedCryDear merged 4 commits into
mainfrom
feat/qwen-runtimes

Conversation

@YouNeedCryDear
Copy link
Copy Markdown
Collaborator

@YouNeedCryDear YouNeedCryDear commented Mar 3, 2026

What this PR does

  • Fixes quantization config parsing for Qwen model configurations.
  • Adds Qwen 3.5 model config parsing support and fixtures.
  • Expands unit test coverage across Qwen parser variants, including FP8 cases.

Why we need it

Current parsing for newer Qwen model quantization config is incomplete/inaccurate in some cases, which can lead to incorrect model metadata extraction. These updates improve correctness and add regression coverage.

Fixes #

How to test

  • go test ./pkg/hfutil/modelconfig/...

Checklist

  • Tests added/updated (if applicable)
  • Docs updated (if applicable)
  • make test passes locally

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions github-actions Bot added models Model configuration changes tests Test changes labels Mar 3, 2026
@YouNeedCryDear YouNeedCryDear changed the title Fix Qwen quantization parsing and add Qwen 3.5 model config tests (feat)(fix) Fix Qwen quantization parsing and add Qwen 3.5 model config tests Mar 3, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ecf4c8c368

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pkg/hfutil/modelconfig/qwen3_vl.go
Comment thread pkg/hfutil/modelconfig/qwen2_test.go
@YouNeedCryDear YouNeedCryDear merged commit aa0c508 into main Mar 6, 2026
29 checks passed
@YouNeedCryDear YouNeedCryDear deleted the feat/qwen-runtimes branch March 6, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

models Model configuration changes tests Test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants