[Core] Refactor quantization parsing into base model config#557
Open
YouNeedCryDear wants to merge 3 commits intomainfrom
Open
[Core] Refactor quantization parsing into base model config#557YouNeedCryDear wants to merge 3 commits intomainfrom
YouNeedCryDear wants to merge 3 commits intomainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
heymrbox
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
BaseModelConfigphito rely on the shared base model config behaviorWhy we need it
The
HuggingFaceModelinterface requires every model configuration object to implement theGetQuantizationType() stringmethod. Currently, over 30 distinct architectural implementations (e.g.,QwenConfig,LlamaConfig,DeepseekV3Config) successfully satisfy this requirement.However, almost none of these implementations utilize a centralized method. As a result, 90% of the model implementation files contain identical copy-pasted blocks redefining the JSON configuration struct and the accessor method:
This consolidates quantization parsing in one place so model config implementations stay consistent and easier to maintain. It also removes duplicated parsing paths that had drifted across individual model types.
Fixes #
How to test
go test ./pkg/hfutil/modelconfiggo test ./pkg/hfutil/...in an environment that allowshttptestto bind local ports forpkg/hfutil/hubtestsChecklist
make testpasses locally