[Misc] Fix staticcheck findings under pkg/#558
Merged
Conversation
heymrbox
requested review from
CatherineSue,
YouNeedCryDear,
beiguo218,
pallasathena92,
slin1237 and
truddy0
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
github-actions
Bot
added
auth
| } | ||
|
|
||
| // buildS3URI constructs an S3 URI from bucket and key | ||
| func buildS3URI(bucket, key string) string { |
Collaborator
There was a problem hiding this comment.
we delete this because we didn't use it?
we don't have download from s3 and gcp for now, but we will keep this helper function for others use s3 and gcp.
Collaborator
Author
There was a problem hiding this comment.
good call, restored them
| } | ||
|
|
||
| // Check model format | ||
| if format.ModelFormat != nil && &model.ModelFormat != nil { |
Collaborator
There was a problem hiding this comment.
just remove &model.ModelFormat != nil
| cloud.google.com/go/auth v0.16.1/go.mod h1:1howDHJ5IETh/LwYs3ZxvlkXF48aSqqJUM+5o02dNOI= | ||
| cloud.google.com/go/auth/oauth2adapt v0.2.8 h1:keo8NaayQZ6wimpNSmW5OPc283g65QNIiLpZnkHRbnc= | ||
| cloud.google.com/go/auth/oauth2adapt v0.2.8/go.mod h1:XQ9y31RkqZCcwJWNSx2Xvric3RrU88hAYYbjDWYDL+c= | ||
| cloud.google.com/go/automl v1.14.4/go.mod h1:sVfsJ+g46y7QiQXpVs9nZ/h8ntdujHm5xhjHW32b3n4= |
Collaborator
There was a problem hiding this comment.
would you try to tidy go sum here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fix static analysis issues in pkg/
Why we need it
staticcheck reports multiple issues under pkg/.
Fixes #556
How to test
make test
Checklist
make testpasses locally