[Misc] add multi modal model fallback in generic model config parse#589
Merged
pallasathena92 merged 1 commit intomainfrom Apr 25, 2026
Merged
[Misc] add multi modal model fallback in generic model config parse#589pallasathena92 merged 1 commit intomainfrom
pallasathena92 merged 1 commit intomainfrom
Conversation
slin1237
approved these changes
Apr 25, 2026
5717c5f to
f0d62c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
estimateMoEParams()fromdeepseek_vl.goto interface.go as a shared utilityWhy we need it
When an unregistered multimodal model (e.g., composite vision-language-audio models) falls back to GenericModelConfig, critical fields like hidden_size, max_position_embeddings, and transformers_version are
missed because they are nested under keys like llm_config, text_config, or language_config. This causes:
What changes in this PR
pkg/hfutil/modelconfig/interface.gopkg/hfutil/modelconfig/deepseek_vl.gopkg/hfutil/modelconfig/interface_test.goFixes #
How to test
Checklist
make testpasses locally