[MISC] Fix Safetensors Version from 1 to 1.0.0 in Runtime#84
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @YouNeedCryDear, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug where the system's runtime configurations were expecting a safetensors model format version of "1" while models were providing "1.0.0", leading to runtime errors. The changes update all relevant existing runtime definitions and documentation to consistently use "1.0.0" for safetensors model versions, and also introduce new runtime configurations that adhere to this corrected standard. This ensures proper model loading and compatibility within the system.
Highlights
- Runtime Configuration Updates: Updated the
safetensorsmodel format version from"1"to"1.0.0"across numerous existing runtime configuration files (bothsrtandvllmtypes) to resolve a version mismatch error. - New Runtime Definitions: Introduced two new
ClusterServingRuntimeconfigurations,srt-llama-3-1-405b-instruct-fp8-pdandsrt-llama-3-3-70b-instruct-pd, which correctly specify thesafetensorsversion as"1.0.0"from their inception. - Documentation Alignment: Synchronized the
safetensorsversion string in thebase_model.mdandserving_runtime.mddocumentation files to"1.0.0"to reflect the correct and supported format.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the safetensors version from "1" to "1.0.0" in multiple runtime configuration files and documentation to address a version incompatibility issue. Two new ClusterServingRuntime configurations are also introduced.
* fix safetensor version in rt * remove pd runtime for now
What type of PR is this?
bug
What this PR does / why we need it:
Fix Safetensors Version from 1 to 1.0.0 in Runtime
Error in OME manager: