Skip to content

[MISC] Fix Safetensors Version from 1 to 1.0.0 in Runtime#84

Merged
slin1237 merged 2 commits into
mainfrom
fix/rt-safetensor-version
Jun 27, 2025
Merged

[MISC] Fix Safetensors Version from 1 to 1.0.0 in Runtime#84
slin1237 merged 2 commits into
mainfrom
fix/rt-safetensor-version

Conversation

@YouNeedCryDear
Copy link
Copy Markdown
Collaborator

What type of PR is this?

bug

What this PR does / why we need it:

Fix Safetensors Version from 1 to 1.0.0 in Runtime
Error in OME manager:

github.com/sgl-project/ome/pkg/controller/v1beta1/inferenceservice.(*InferenceServiceReconciler).Reconcile```
<!-- 
Please include a summary of the changes and which issue is fixed. 
Include relevant motivation and context.
-->

## Which issue(s) this PR fixes:

<!-- 
Automatically closes linked issue when PR is merged.
Usage: Fixes #<issue number>, or Fixes (paste link of issue).
-->
Fixes #

## Special notes for your reviewer:

<!-- 
Any specific areas you'd like reviewed? Any concerns?
-->

## Does this PR introduce a user-facing change?

<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->

```release-note

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @YouNeedCryDear, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug where the system's runtime configurations were expecting a safetensors model format version of "1" while models were providing "1.0.0", leading to runtime errors. The changes update all relevant existing runtime definitions and documentation to consistently use "1.0.0" for safetensors model versions, and also introduce new runtime configurations that adhere to this corrected standard. This ensures proper model loading and compatibility within the system.

Highlights

  • Runtime Configuration Updates: Updated the safetensors model format version from "1" to "1.0.0" across numerous existing runtime configuration files (both srt and vllm types) to resolve a version mismatch error.
  • New Runtime Definitions: Introduced two new ClusterServingRuntime configurations, srt-llama-3-1-405b-instruct-fp8-pd and srt-llama-3-3-70b-instruct-pd, which correctly specify the safetensors version as "1.0.0" from their inception.
  • Documentation Alignment: Synchronized the safetensors version string in the base_model.md and serving_runtime.md documentation files to "1.0.0" to reflect the correct and supported format.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the safetensors version from "1" to "1.0.0" in multiple runtime configuration files and documentation to address a version incompatibility issue. Two new ClusterServingRuntime configurations are also introduced.

@slin1237 slin1237 merged commit 5c48fd3 into main Jun 27, 2025
15 checks passed
@slin1237 slin1237 deleted the fix/rt-safetensor-version branch June 27, 2025 19:28
slin1237 pushed a commit that referenced this pull request Dec 22, 2025
* fix safetensor version in rt

* remove pd runtime for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants