Skip to content

Guard stale UE release-complete during handover; harden RanUe attach#704

Merged
gab-arrobo merged 4 commits into
omec-project:mainfrom
gab-arrobo:guard-stale
May 16, 2026
Merged

Guard stale UE release-complete during handover; harden RanUe attach#704
gab-arrobo merged 4 commits into
omec-project:mainfrom
gab-arrobo:guard-stale

Conversation

@gab-arrobo
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves NGAP UE context release handling around handover/stale RanUe scenarios, and tightens AmfUe↔RanUe attachment behavior to reduce incorrect detaches.

Changes:

  • Remove RanUe contexts on UEContextReleaseComplete when the associated AmfUe is missing, and add a “stale RanUe” guard to avoid detaching the current RanUe.
  • Add unit tests for stale RanUe removal and handover target promotion on UEContextReleaseComplete.
  • Adjust AmfUe.AttachRanUe behavior and refactor log updates into a helper.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
ngap/handler.go Adds stale/invalid RanUe handling during UEContextReleaseComplete.
ngap/handler_test.go Adds regression tests for stale RanUe removal and handover behavior.
context/amf_ue.go Hardens attach logic and refactors log setup for attached RanUe.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ngap/handler.go
Comment thread context/amf_ue.go Outdated
Comment thread context/amf_ue.go
Comment thread ngap/handler_test.go
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread ngap/handler.go
Comment thread ngap/handler.go Outdated
Comment thread ngap/handler_test.go Outdated
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Comment thread ngap/handler_test.go Outdated
Comment thread context/amf_ue.go
Comment thread context/amf_ue.go
Comment thread ngap/handler_test.go Outdated
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@gab-arrobo gab-arrobo merged commit a6b6ee5 into omec-project:main May 16, 2026
12 checks passed
@gab-arrobo gab-arrobo deleted the guard-stale branch May 16, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants